[
https://issues.apache.org/jira/browse/HADOOP-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656247#action_12656247
]
Hadoop QA commented on HADOOP-4838:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12395907/4838-2.patch
against trunk revision 726129.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 6 new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3730/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3730/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3730/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3730/console
This message is automatically generated.
> Cleanup Metrics and the MBeans
> ------------------------------
>
> Key: HADOOP-4838
> URL: https://issues.apache.org/jira/browse/HADOOP-4838
> Project: Hadoop Core
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Sanjay Radia
> Attachments: 4838-1.patch, 4838-2.patch
>
>
> This patch cleans up the metrics to make it easier to write metrics and the
> mbeans.
> Added a registry to the metrics so that the pushing of metrics can be done
> automatically.
> Also this registry is used to create dynamic mbeans from metrics.
> Added the dynamic mbeans base and changed the existing activity beans to use
> them.
> Also cleanup the names of the mbeans.
> Hence each time a new metrics is added to an existing set of metrics, one
> needs to simply do
> 1) add the metrics to a holder class (such as NameNodeMetrics
> 2) add code to update the metrics.
> The metrics will be pushed as per metrics config and it will also be
> published via mbeans.
> (Previous to this patch also has to add a line of code to push and add new
> mbean entries).
> If one is adding a new category of metrics (ie for which a holder class does
> *not* exist) then
> 1) create metrics holder (see NameNodeMetrics as an example)
> 2) create mbean (see NameNodeActivityMBean as an example)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
