[
https://issues.apache.org/jira/browse/HADOOP-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arun C Murthy updated HADOOP-4838:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Sanjay!
> Cleanup Metrics and the MBeans
> ------------------------------
>
> Key: HADOOP-4838
> URL: https://issues.apache.org/jira/browse/HADOOP-4838
> Project: Hadoop Core
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Sanjay Radia
> Fix For: 0.20.0
>
> Attachments: 4838-1.patch, 4838-2.patch, 4838-3.patch, 4838-4.patch
>
>
> This patch cleans up the metrics to make it easier to write metrics and the
> mbeans.
> Added a registry to the metrics so that the pushing of metrics can be done
> automatically.
> Also this registry is used to create dynamic mbeans from metrics.
> Added the dynamic mbeans base and changed the existing activity beans to use
> them.
> Also cleanup the names of the mbeans.
> Hence each time a new metrics is added to an existing set of metrics, one
> needs to simply do
> 1) add the metrics to a holder class (such as NameNodeMetrics
> 2) add code to update the metrics.
> The metrics will be pushed as per metrics config and it will also be
> published via mbeans.
> (Previous to this patch also has to add a line of code to push and add new
> mbean entries).
> If one is adding a new category of metrics (ie for which a holder class does
> *not* exist) then
> 1) create metrics holder (see NameNodeMetrics as an example)
> 2) create mbean (see NameNodeActivityMBean as an example)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
