[
https://issues.apache.org/jira/browse/HADOOP-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663874#action_12663874
]
Ari Rabkin commented on HADOOP-5033:
------------------------------------
The other option, as I think about it, is to ditch the list version and only
have add(Chunk). The one class where add(List) is different is that in
SeqFileWriter, it caches the computation of the time partition. But it might
be sensible to just push that into a timer, and have only the simpler add
method.
There's no interesting semantic behind which Chunks go in the same list --an
HTTP post to the collector doesn't have interesting semantics. So ditching
add(List<>) will prevent mistaken assumptions.
> chukwa writer API is confusing
> ------------------------------
>
> Key: HADOOP-5033
> URL: https://issues.apache.org/jira/browse/HADOOP-5033
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Priority: Minor
>
> The ChukwaWriter interface has both add(Chunk) and add(List<Chunk>). The
> code doesn't actually use the former. I'd like to remove it. Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
