[ 
https://issues.apache.org/jira/browse/HADOOP-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663918#action_12663918
 ] 

Ari Rabkin commented on HADOOP-5033:
------------------------------------

I'm convinced by the point about transactions.  So add(Chunk) will go, and 
add(List) will stay.  

As to warnings or errors -- this is in the context of Writers, on the collector 
side.  So there's an easy error reporting mechanism: the writer should throw a 
WriterException if it isn't willing to take responsibility for the chunks in 
the list.

> chukwa writer API is confusing
> ------------------------------
>
>                 Key: HADOOP-5033
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5033
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/chukwa
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Minor
>
> The ChukwaWriter interface has both add(Chunk) and add(List<Chunk>).   The 
> code doesn't actually use the former.  I'd like to remove it.  Thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to