[
https://issues.apache.org/jira/browse/HADOOP-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666360#action_12666360
]
Doug Cutting commented on HADOOP-5045:
--------------------------------------
There are some whitespace changes and additions of serialVersionUID in your
patch that should not be there.
The most common case we'd like to fix is where listStatus() is used, then one
needlessly calls isDirectory() on each path listed rather than using the
status, so the javadoc should mention listStatus() as well as getStatus(). The
methods this patch modifies in FileUtil are examples of this. If the src
parameter of copy() and copyMerge() were FileStatus rather than Path then a
call to getStatus could be avoided. A fix is to add private methods with these
new parameters, and have the public methods call getStatus and pass the value
to the private methods which then walk the directory tree.
> Remove deprecated FileSystem.isDirectory()
> ------------------------------------------
>
> Key: HADOOP-5045
> URL: https://issues.apache.org/jira/browse/HADOOP-5045
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Suresh Srinivas
> Attachments: 5045.patch
>
>
> We should remove FileSystem.isDirectory().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
