[ 
https://issues.apache.org/jira/browse/HADOOP-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666362#action_12666362
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5045:
------------------------------------------------

- We should use fs.getFileStatus(src).isDir(), instead of fs.isDirectory(src) , 
in the cases that src must exist or the operation must abort.  Found these 
cases in
-* ChecksumFileSystem line 402 and line 499
-* FsShell line 1034 and line 1087

- FsShell.copyFromStdin(..) should use getFileStatus for checking exist and 
isDir in one shot.

- In FsShell line 835, srcFs.isDirectory(dst) looks like a bug since it uses 
srcFs with dst path.

> Remove deprecated FileSystem.isDirectory()
> ------------------------------------------
>
>                 Key: HADOOP-5045
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5045
>             Project: Hadoop Core
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Suresh Srinivas
>         Attachments: 5045.patch
>
>
> We should remove FileSystem.isDirectory().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to