[
https://issues.apache.org/jira/browse/HADOOP-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668450#action_12668450
]
Devaraj Das commented on HADOOP-2721:
-------------------------------------
Looks good overall. Some comments:
1) The ProcessTree class could have destroy methods that take a boolean to
decide whether to destroy the process group or a single process.
2) We can avoid calling the ProcfsBasedProcessTree.destroyProcess calls in
JvmManager and only call the ProcessTree.destroy. The only thing that is
additionally checked for in the ProcfsBasedProcessTree.destroyProcess is
whether the pid passed is the process group leader. In our usecase, we are sure
that this pid IS the process group leader...
Longer term, we should consider refactoring the ProcessTree class so that it is
a generic class with specific implementations like ProcfsBasedProcessTree and
others deriving from it and overriding methods, much like the hierarchy we have
for the FileSystem classes..
> Use job control for tasks (and therefore for pipes and streaming)
> -----------------------------------------------------------------
>
> Key: HADOOP-2721
> URL: https://issues.apache.org/jira/browse/HADOOP-2721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/streaming, mapred, pipes
> Reporter: Owen O'Malley
> Assignee: Ravi Gummadi
> Attachments: HADOOP-2721-v10.patch, HADOOP-2721-v11.1.patch,
> HADOOP-2721-v11.3.patch, HADOOP-2721-v11.patch, HADOOP-2721-v2.patch,
> HADOOP-2721-v3.patch, HADOOP-2721-v9.patch, HADOOP-2721.patch,
> HADOOP-2721.patch, HADOOP-2721.patch
>
>
> We should use the setsid command when the task is launched to create a new
> session. We should be able to use the setsid program when we launch the bash
> process to create a new session. That will allow us to kill the entire
> session with a single signal and remove the need for the ping methods in both
> TaskTracker.Child and pipes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
