[ 
https://issues.apache.org/jira/browse/HADOOP-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668834#action_12668834
 ] 

Ravi Gummadi commented on HADOOP-2721:
--------------------------------------

ant test-patch gave:

     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 6 new or 
modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec]
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath 
integrity.

Unit tests also passed on my local machine.

> Use job control for tasks (and therefore for pipes and streaming)
> -----------------------------------------------------------------
>
>                 Key: HADOOP-2721
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2721
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/streaming, mapred, pipes
>            Reporter: Owen O'Malley
>            Assignee: Ravi Gummadi
>         Attachments: HADOOP-2721-v10.patch, HADOOP-2721-v11.1.patch, 
> HADOOP-2721-v11.3.patch, HADOOP-2721-v11.4.patch, HADOOP-2721-v11.patch, 
> HADOOP-2721-v2.patch, HADOOP-2721-v3.patch, HADOOP-2721-v9.patch, 
> HADOOP-2721.patch, HADOOP-2721.patch, HADOOP-2721.patch
>
>
> We should use the setsid command when the task is launched to create a new 
> session. We should be able to use the setsid program when we launch the bash 
> process to create a new session. That will allow us to kill the entire 
> session with a single signal and remove the need for the ping methods in both 
> TaskTracker.Child and pipes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to