[ 
https://issues.apache.org/jira/browse/HADOOP-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678143#action_12678143
 ] 

Hairong Kuang commented on HADOOP-5358:
---------------------------------------

command-line arguments parsing:
when -scriptFile is specified, makes sure that neither rp, wp, nor ealspsed 
time is specified.
 
loadScriptFile:
1. should put file close in finally to make the script file is closed even if 
errors occur when reading the file;
2. better check the validity of read and write probabilities (r+w should 
smaller than 1) while reading the script file so no need to continue reading if 
there is an invalid parameter.
3. could use List.toArray to do the array conversion;
4. what if the script file contains no valid lines

> Provide scripting functionality to the synthetic load generator
> ---------------------------------------------------------------
>
>                 Key: HADOOP-5358
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5358
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: test
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>            Priority: Minor
>         Attachments: HADOOP-5358.patch
>
>
> Currently the load generator accepts parameters at start time as to the read 
> and write probabilities to apply against the namenode.  It would be useful to 
> be able to provide it with a script of these values, so that they can be 
> varied over time.  This would allow the namenode to be tested with varying 
> loads over time so its behavior to changing loads can be examined.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to