[ 
https://issues.apache.org/jira/browse/HADOOP-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678446#action_12678446
 ] 

Hairong Kuang commented on HADOOP-5358:
---------------------------------------

The changes look good. One more comment: it looks that you allow duration to be 
0 in the script file. Then the main thread should handle zero duration 
correctly. I would prefer that no 0 duration is allowed in the script file. If 
you really want to support the feature, only the last duration is allowed to be 
zero.

Also could you please update the synthetic load generator document?

> Provide scripting functionality to the synthetic load generator
> ---------------------------------------------------------------
>
>                 Key: HADOOP-5358
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5358
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: test
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>            Priority: Minor
>         Attachments: HADOOP-5358.patch, HADOOP-5358.patch, HADOOP-5358.patch
>
>
> Currently the load generator accepts parameters at start time as to the read 
> and write probabilities to apply against the namenode.  It would be useful to 
> be able to provide it with a script of these values, so that they can be 
> varied over time.  This would allow the namenode to be tested with varying 
> loads over time so its behavior to changing loads can be examined.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to