[
https://issues.apache.org/jira/browse/HADOOP-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678147#action_12678147
]
Suresh Srinivas commented on HADOOP-4756:
-----------------------------------------
# General
## nits - Coding conventions - have consistent convention for space before and
after assignemtn {{=}}). Space is required after {{if}}, {{for}}, {{,}} and
parenthesis around the {{if}} statement.
## debug logs are sent to {{err}}. Not sure if that is the right thing to do.
## Where possible, instead of catching {{Exception}}, catch more specific
exceptions expected
## There is a difference in exceptions caught in {{getValue{}}} compared
{{printAllValues()}}. Should they be the same?
# {{hdfs}}
## Add new command jmxget to the usage
# {{JMXGet.java}}
## Following imports are not used:
{noformat}
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.conf.Configured;
import org.apache.hadoop.util.Tool;
import org.apache.hadoop.util.ToolRunner;
{noformat}
## Move member variables to the top of the class
## {{main()}} Like other commands such as {{DFSAdmin.java}} should we use
ToolRunner to start this tool?
## {{JMXGet()}} Constructor comments are not right - there is no conf param.
## {{run()}} Method comments are not right. There is not parameter {{args}}
## {{parseArgs()}} instead of catching ParserException, should it be thrown?
That way {{init()}} or {{run()}} can catch it and do the required error
processing
## {{init()}}
### Should only throw {{IOException}} not generic {{Exception}}
### defined {{port}}, {{server}} as static String variables such as
{{DEFAULT_PORT}}, {{DEFAULT_SERVER}}
### No need to catch exception while doing {{JMXConnectorFactory.connect()}},
as it can be caught by {{run()}}
### Remove commented code in the {{for}} loop
## {{printUsage()}} method comment says GMX instead of JMX
## {{printAllValues()}} should method comment be saying {{Print all the
attribute values}}?
> Create a command line tool to access JMX exported properties from a NameNode
> server
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4756
> URL: https://issues.apache.org/jira/browse/HADOOP-4756
> Project: Hadoop Core
> Issue Type: New Feature
> Components: dfs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-4756.patch, HADOOP-4756.patch, HADOOP-4756.patch
>
>
> Create a command line tool that will easy script access to JMX exported
> properties of the NameNode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
