[
https://issues.apache.org/jira/browse/HADOOP-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680309#action_12680309
]
Suresh Srinivas commented on HADOOP-4756:
-----------------------------------------
Some minor nits:
# {{JMXGet.getValue()}} {{err()}} print statement can be simply changed to
{{err("Info: key = " + key + "; val = " + val);}}
# {{JMXGet.init()}} always returns zero. So it could be made to return {{void}}
# {{JMXGet.parseArgs()}} it may be a good idea to use static methods invoked
with class name so that code looks clean on eclipse. Typo {{invalide}} in
exception. Not sure if not catching the {{IllegalArgumentException}} from
{{parseArgs()}} in {{main()}} is intentional. Does this return -1 from the
script?
# {{JMXGet.main()}} null {{value}} is not printed. Could null be a valid value
that needs to be printed?
# {{TestJMXGet.java}} does not compile because of the last line. Also it might
be a good idea to include tests for running the command with server:port and
localVM option.
> Create a command line tool to access JMX exported properties from a NameNode
> server
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-4756
> URL: https://issues.apache.org/jira/browse/HADOOP-4756
> Project: Hadoop Core
> Issue Type: New Feature
> Components: dfs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-4756-1.patch, HADOOP-4756-2.patch,
> HADOOP-4756.patch, HADOOP-4756.patch, HADOOP-4756.patch
>
>
> Create a command line tool that will easy script access to JMX exported
> properties of the NameNode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
