[ https://issues.apache.org/jira/browse/HADOOP-5509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698734#action_12698734 ]
Hadoop QA commented on HADOOP-5509: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12405352/PendingReplication.patch against trunk revision 764605. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/195/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/195/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/195/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/195/console This message is automatically generated. > PendingReplicationBlocks should not start monitor in constructor. > ----------------------------------------------------------------- > > Key: HADOOP-5509 > URL: https://issues.apache.org/jira/browse/HADOOP-5509 > Project: Hadoop Core > Issue Type: Improvement > Components: dfs > Affects Versions: 0.20.0 > Reporter: Konstantin Shvachko > Assignee: Konstantin Shvachko > Fix For: 0.21.0 > > Attachments: PendingReplication.patch > > > {{PendingReplicationBlocks}} starts {{PendingReplicationMonitor}} inside the > constructor. > Monitor should be started by a separate method, which should be called in > {{NameNode.activate()}} -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.