[
https://issues.apache.org/jira/browse/HADOOP-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698992#action_12698992
]
Tsz Wo (Nicholas), SZE commented on HADOOP-5650:
------------------------------------------------
+1 patch looks good.
A nit: seems to me that the following is more clear.
{code}
boolean needEnter() {
return threshold != 0 && blockSafe < blockThreshold;
}
{code}
> Namenode log that indicates why it is not leaving safemode may be confusing
> ---------------------------------------------------------------------------
>
> Key: HADOOP-5650
> URL: https://issues.apache.org/jira/browse/HADOOP-5650
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Minor
> Attachments: 5650.patch
>
>
> A namenode with a large number of datablocks is setup with
> dfs.safemode.threshold.pct set to 1.0. With a small number of unreported
> blocks, namenode prints the following as the reason for not leaving safe mode:
> {{The ratio of reported blocks 1.0000 has not reached the threshold 1.0000}}
> With a large number of blocks, precision used for printing the log may not
> indicate the difference between the actual ratio of safe blocks to total
> blocks and the configured threshold. Printing number of blocks instead of
> ratio will improve the clarity.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
