[ https://issues.apache.org/jira/browse/HADOOP-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699940#action_12699940 ]
Hadoop QA commented on HADOOP-5650: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12405479/5650.patch against trunk revision 765713. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/202/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/202/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/202/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/202/console This message is automatically generated. > Namenode log that indicates why it is not leaving safemode may be confusing > --------------------------------------------------------------------------- > > Key: HADOOP-5650 > URL: https://issues.apache.org/jira/browse/HADOOP-5650 > Project: Hadoop Core > Issue Type: Bug > Reporter: Suresh Srinivas > Assignee: Suresh Srinivas > Priority: Minor > Attachments: 5650.patch, 5650.patch > > > A namenode with a large number of datablocks is setup with > dfs.safemode.threshold.pct set to 1.0. With a small number of unreported > blocks, namenode prints the following as the reason for not leaving safe mode: > {{The ratio of reported blocks 1.0000 has not reached the threshold 1.0000}} > With a large number of blocks, precision used for printing the log may not > indicate the difference between the actual ratio of safe blocks to total > blocks and the configured threshold. Printing number of blocks instead of > ratio will improve the clarity. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.