[
https://issues.apache.org/jira/browse/HADOOP-5419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699519#action_12699519
]
Sreekanth Ramakrishnan commented on HADOOP-5419:
------------------------------------------------
* Karam's comment about case where no user has access to any queue comment has
not been handled. If user cannot submit to any queues which are configured, the
appropriate message should be shown instead of blank line.
* Correct JavaDoc in {{JobSubmissionProtocol}} for
{{getCurrentUserQueueAclsInfo()}}
* Error message in {{JobTracker.submitJob(JobID)}} can we change it to what
Eric has commented?
* In {{QueueManager}} {{getCurrentUserQueueAclsInfo()}} can we
{{operationsAllowed}} create it and keep it instead of trying to create it
lazily? would defintely improve readability of the code.
* Minor nit the indendation in the {{getCurrentUserQueueAclsInfo()}} seems to
be incorrect.
* Why are we doing checking if user has access or not in
{{getCurrentUserQueueAclsInfo()}}? Cant we make the code in the method much
simpler? As follows
{noformat}
for each queues:
for each operation:
allowed = hasAccess(queue, operation, ugi)
if(allowed)
add to operation allowed list
create queue acls info object based on operations allowed list.
{noformat}
> Provide a way for users to find out what operations they can do on which M/R
> queues
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-5419
> URL: https://issues.apache.org/jira/browse/HADOOP-5419
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Hemanth Yamijala
> Assignee: rahul k singh
> Attachments: commands_manual.pdf, hadoop-5419-1.patch,
> hadoop-5419.patch, hadoop-5419.patch, hadoop-5419.patch, hadoop-5419.patch
>
>
> This issue is to provide an improvement on the existing M/R framework to let
> users know which queues they have access to, and for what operations. One use
> case for this would that currently there is no easy way to know if the user
> has access to submit jobs to a queue, until it fails with an access control
> exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
