[ 
https://issues.apache.org/jira/browse/HADOOP-5419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707296#action_12707296
 ] 

Hemanth Yamijala commented on HADOOP-5419:
------------------------------------------

Close, but a little more work:

- In displayQueueAclsInfoForCurrentUser, when no ACLs are returned, we are 
using UserGroupInformation.getCurrentUGI().getUserName(). This could be null if 
the login is not done, right ?
- I would recommend that the JobClient API be changed to 
getQueueAclsForCurrentUser, and the java doc updated accordingly.
- QueueManager API need not be called getCurrentUserQueueAclsInfo, as we are 
passing a UGI. Let's just call it getQueueAcls(UGI ugi)
- Javadoc for the QueueManager API is still saying 'current user' though we are 
passing in the UGI.
- java.util.Iterator is not needed in QueueManager, I think, Can you check
- I think the formatting of the QueueAclsInfo in the toString is not right. 
Let's keep all formatting in JobQueueClient API and remove the toString
- 

> Provide a way for users to find out what operations they can do on which M/R 
> queues
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-5419
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5419
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Hemanth Yamijala
>            Assignee: rahul k singh
>         Attachments: commands_manual.pdf, hadoop-5419-1.patch, 
> hadoop-5419-1.patch, hadoop-5419-2.patch, hadoop-5419-2.patch, 
> hadoop-5419-3.patch, hadoop-5419-4.patch, hadoop-5419.patch, 
> hadoop-5419.patch, hadoop-5419.patch, hadoop-5419.patch
>
>
> This issue is to provide an improvement on the existing M/R framework to let 
> users know which queues they have access to, and for what operations. One use 
> case for this would that currently there is no easy way to know if the user 
> has access to submit jobs to a queue, until it fails with an access control 
> exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to