[ 
https://issues.apache.org/jira/browse/HADOOP-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Zeyliger updated HADOOP-5687:
------------------------------------

    Attachment: HADOOP-5687.patch

bq.   1.  Make DFS_URI_SCHEME final
Done.
bq.   2. NameNode.getAddress()
bq.        * use authority that you already have to return as 
getAddress(authority)
Oops, done.
bq.          * use FS_DEFAULT_NAME_KEY instead of hardcoded conf name 
"fs.default.name"
Done.  I had to make FS_DEFAULT_NAME_KEY public.
bq.   3. Hard coded "hdfs" can be replaced with DFS_URI_SCHEME in 
SecondaryNameNode.getInforServer()
Done.

Thanks for the suggestions!  I've uploaded a new patch.



> Hadoop NameNode throws NPE if fs.default.name is the default value
> ------------------------------------------------------------------
>
>                 Key: HADOOP-5687
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5687
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Philip Zeyliger
>            Priority: Minor
>         Attachments: HADOOP-5687.patch, HADOOP-5687.patch
>
>
> Throwing NPE is confusing; instead, an exception with a useful string 
> description could be thrown instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to