[
https://issues.apache.org/jira/browse/HADOOP-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699900#action_12699900
]
Konstantin Shvachko commented on HADOOP-5687:
---------------------------------------------
> Would you prefer that I add the check to throw IllegalArgumentException in
> NetUtils?
Yes, because it will work for other modules like JobTracker as well as the
name-node.
> I feel like I'd have to keep an if statement (or catch the
> IllegalArgumentException) in NameNode to keep the nice error message.
By generating the description in the name-node you can only add that this is
coming from the NameNode. But that will be seen in the stack trace one way or
another.
> I don't think Hadoop checks for "hdfs" higher in the stack; I set
> fs.default.name to hdXXXXfs://doorstop.local/, and the check was triggered.
If you get address from {{FileSystem}}, and it is not hdfs then other file
system code (LocalFileSystem or kfs or S3) will be triggered.
But when we start name-node, yes you are right, we should check the scheme. Not
an assert.
> Hadoop NameNode throws NPE if fs.default.name is the default value
> ------------------------------------------------------------------
>
> Key: HADOOP-5687
> URL: https://issues.apache.org/jira/browse/HADOOP-5687
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Philip Zeyliger
> Priority: Minor
> Attachments: HADOOP-5687.patch, HADOOP-5687.patch
>
>
> Throwing NPE is confusing; instead, an exception with a useful string
> description could be thrown instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
