[
https://issues.apache.org/jira/browse/HADOOP-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710804#action_12710804
]
Suresh Srinivas commented on HADOOP-5857:
-----------------------------------------
This is good refactoring. Some comments:
# {{DatanodeJspHelper.generateFileDetails()}} - while forming downloadURL there
is an extra +
# {{NodeListJsp.counterReset()}} does not set {{colNum}} to zero?
# {{NodeListJsp.generateNodeData}} initial comments could be more readable if
the bullets are in separate line
# Not sure where the code related some of the methods from
{{...namenode.JspHelper}} is?
> Refactor hdfs jsp codes
> -----------------------
>
> Key: HADOOP-5857
> URL: https://issues.apache.org/jira/browse/HADOOP-5857
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 5857_20090518.patch
>
>
> There are some normal java methods defiend in .jsp files. It would be easier
> if these methods are moved to normal .java files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
