[
https://issues.apache.org/jira/browse/HADOOP-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710831#action_12710831
]
Tsz Wo (Nicholas), SZE commented on HADOOP-5857:
------------------------------------------------
Note that, before applying the patch, run
svn mv src/hdfs/org/apache/hadoop/hdfs/server/namenode/JspHelper.java
src/hdfs/org/apache/hadoop/hdfs/server/common/JspHelper.java
cp src/hdfs/org/apache/hadoop/hdfs/server/common/JspHelper.java
src/hdfs/org/apache/hadoop/hdfs/server/namenode/JspHelper.java
After applied the patch, do svn add and svn rm.
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
{noformat}
This is a code refactoring. No new tests added.
> Refactor hdfs jsp codes
> -----------------------
>
> Key: HADOOP-5857
> URL: https://issues.apache.org/jira/browse/HADOOP-5857
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 5857_20090518.patch, 5857_20090519.patch
>
>
> There are some normal java methods defiend in .jsp files. It would be easier
> if these methods are moved to normal .java files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
