[
https://issues.apache.org/jira/browse/HADOOP-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710959#action_12710959
]
Konstantin Boudnik commented on HADOOP-5867:
--------------------------------------------
Thanks for review Nicholas.
Some comments:
1) Oops, will fix long lines
2) I though of making exactly this change (the first version of the patch
contains this very change). However, it might be troublesome in some cases,
because fileSys.rename can return false in some cases (say, namespace won't
rename the path) and then we might stuck in this loop forever
(code)
do {
...
while (!success);
(/code)
That's why I've left it as is and put this comment in both (rename and delete)
cases. I'll appreciate to hear from you on this before I'll submit the update
to
this patch.
3) nice catch! Fixed along with a couple of other excessive castings to double.
Thanks in advance,
Cos
> Cleaning NNBench* off javac warnings
> ------------------------------------
>
> Key: HADOOP-5867
> URL: https://issues.apache.org/jira/browse/HADOOP-5867
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.20.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-5867.patch, HADOOP-5867.patch
>
>
> These files have a number of javac 'class depricated' warnings
> src/test/hdfs-with-mr/org/apache/hadoop/hdfs/NNBench.java
> src/test/hdfs-with-mr/org/apache/hadoop/hdfs/NNBenchWithoutMR.java
> It is possible to fix most of them plus make some readability improvements on
> the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
