[
https://issues.apache.org/jira/browse/HADOOP-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin Boudnik updated HADOOP-5867:
---------------------------------------
Attachment: HADOOP-5867.patch
All but one comments from the reviewer were taken into consideration and fixed.
I'm hesitant to used suggestion from the review and modify the code in question
to
success = fileSys.rename(...)
because rename() might return false in three cases our of four existing exit
points.
More generic question is: are we trying to count both false and true return as
success and only exception throwing as a failure?
> Cleaning NNBench* off javac warnings
> ------------------------------------
>
> Key: HADOOP-5867
> URL: https://issues.apache.org/jira/browse/HADOOP-5867
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.20.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-5867.patch, HADOOP-5867.patch, HADOOP-5867.patch
>
>
> These files have a number of javac 'class depricated' warnings
> src/test/hdfs-with-mr/org/apache/hadoop/hdfs/NNBench.java
> src/test/hdfs-with-mr/org/apache/hadoop/hdfs/NNBenchWithoutMR.java
> It is possible to fix most of them plus make some readability improvements on
> the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
