[
https://issues.apache.org/jira/browse/HADOOP-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luca Telloli updated HADOOP-5188:
---------------------------------
Attachment: HADOOP-5188.patch
Ben, thanks for your quick fix list, it has been very useful. I'm posting
another patch that addresses your concerns. Let me comment some of the issues
you outlined:
• in
src/hdfs/org/apache/hadoop/hdfs/server/namenode/EditLogBackupOutputStream.java
and
src/hdfs/org/apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java
get rid of the // TODO comment and explain why it is empty
Method switchEditStreams() for Backup streams and file stream is currently
implemented somewhere else in the code. That code should eventually end up
here, but that should probably be part of a different patch, although strictly
related to this one.
• there are two processIOError in
src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSImage.java. shouldn't there
only be one?
Part of the process of switching to LogDevice might involve duplicating code
until all the dependencies on StorageDirectory are cleared out. This should
eventually disappear in the future and should be the subject of another patch.
• what is the FIXME getNewInputStreamInstance?
The current patch only uses LogDevice for output streams; when it comes to
input the code is basically the same as it was before. This again might be part
of another patch.
When I say "another patch" I'm talking about a collection of patches that would
depend on this one, once committed.
> Modifications to enable multiple types of logging
> --------------------------------------------------
>
> Key: HADOOP-5188
> URL: https://issues.apache.org/jira/browse/HADOOP-5188
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.20.0
> Reporter: Luca Telloli
> Fix For: 0.21.0
>
> Attachments: HADOOP-5188.patch, HADOOP-5188.patch, HADOOP-5188.patch,
> HADOOP-5188.patch, HADOOP-5188.patch, HADOOP-5188.patch, HADOOP-5188.pdf
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
