Le 03/09/2009 01:04, [email protected] a écrit :
Hi, Mandy.
This is related to 6857194: Add hotspot new perf counters to aid class
loading performance measurement.
[ ... ]
Webrev:
http://cr.openjdk.java.net/~mchung/6878481/webrev.00/
Looks good.
iris
In PerfCounter.java,
- static field perf should be final.
- newConstantPerfCounter() seems unused, it's perhaps for a future usage ?
- newPerfCounter(String) should be declared with default visibility
(not private),
currently the compiler generates useless accessors (access$000 etc).
- fields
private String name;
private LongBuffer lb;
should be declared final to avoid race problem,
even if I'am not sure this can happen here because all PerfCounter
constructor calls are done in a <clinit> block i.e under the
protection of a lock.
Rémi
