Alan Bateman wrote:
Xueming Shen wrote:
Alan,
webrev has been updated to use the sun.zip.disableMemoryMapping
http://cr.openjdk.java.net/~sherman/6929479/webrev
Please review.
Thanks,
Sherman
I agree it's a better name. In ZipFile it would be good to put a
comment at the initialization so that the reader understands what this
property is about. Minor nit in zip_util.c at L805 is that it looks
like the indenting it out by one. In any case, this will be a useful
debugging option for the next time that someone steps on their own feet.
-Alan
Thanks Alan.
One comment has been added into ZipFile.
I counted the space in zip_util.c/L805:-) it appears the indenting is
correct. maybe because of font setting?
Sherman
