On Fri, Mar 19, 2010 at 13:29, schrieb Ulf Zibis <[email protected]>: > Am 17.03.2010 16:46, schrieb Martin Buchholz:
> The char is not important here, maybe give hotspot a hint that value is > always positive 16-bit. My idea was to indicate this to the reader. I think naming the variable "plane" and using the ">>>" operator do a good job of making this hint to the reader. > > I saw, that you use to set a space after casts, why? Cast is a one-operand > operator like - -- ++. This a rare style in the JDK sources which "disturbs" > my eyes. ;-) The JDK code I have maintained uses space after cast. We don't have a really well-maintained coding standard, but the closest thing we do have agrees with me: http://java.sun.com/docs/codeconv/html/CodeConventions.doc7.html#475 Nevertheless, you are right - I was surprised that space after cast is less popular in the JDK sources. Martin
