On 7 June 2010 19:06, Xueming Shen <xueming.s...@oracle.com> wrote: > > Andrew, I'm going through the webrev now. Need a little more time. > > -sherman > > Andrew John Hughes wrote: >> >> On 2 June 2010 18:57, Andrew John Hughes <ahug...@redhat.com> wrote: >> >>> >>> When building with JAVAC_MAX_WARNINGS=true, the build fails in >>> sun/nio/cs due to the use of -Werror. >>> >>> The following webrev: >>> >>> http://cr.openjdk.java.net/~andrew/warnings/webrev.03/ >>> >>> fixes the remaining warnings exposed by JAVAC_MAX_WARNINGS by: >>> >>> * Removing redundant casts >>> * Adding generic types to a number of List, Map and Class instances >>> * Turning off deprecation warnings locally in make/sun/nio/cs/Makefile >>> >>> Ok to push? If so, can I have a bug ID for this? >>> >>> Thanks, >>> -- >>> Andrew :-) >>> >>> Free Java Software Engineer >>> Red Hat, Inc. (http://www.redhat.com) >>> >>> Support Free Java! >>> Contribute to GNU Classpath and the OpenJDK >>> http://www.gnu.org/software/classpath >>> http://openjdk.java.net >>> >>> PGP Key: 94EFD9D8 (http://subkeys.pgp.net) >>> Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 >>> >>> >> >> Ping! Any feedback on this? >> > >
Ok, no rush; I didn't know if anyone had even seen the e-mail as there was no response. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
