On Tue, Jun 8, 2010 at 5:47 PM, Andrew John Hughes <ahug...@redhat.com> wrote:
> New webrev:
>
> http://cr.openjdk.java.net/~andrew/warnings/webrev.04/
>
Andrew,
In src/share/classes/sun/nio/cs/ext/HKSCS.java, the following change
seems odd setting a static field in the HKSCS.Decoder constructor. Is
this correct functionality or is big5Dec intended to be an instance
field?
private static DoubleByte.Decoder big5Dec;
protected Decoder(Charset cs,
DoubleByte.Decoder big5Dec,
char[][] b2cBmp, char[][] b2cSupp)
{
// super(cs, 0.5f, 1.0f);
// need to extends DoubleByte.Decoder so the
// sun.io can use it. this implementation
super(cs, 0.5f, 1.0f, null, null, 0, 0);
- this.big5Dec = big5Dec;
+ Decoder.big5Dec = big5Dec;
this.b2cBmp = b2cBmp;
this.b2cSupp = b2cSupp;
}
Thanks,
Dave
