On 10/05/2010 12:18 PM, Alan Bateman wrote:
Xueming Shen wrote:
Thanks! webrev has been updated as suggested.
http://cr.openjdk.java.net/~sherman/6975829/webrev/
<http://cr.openjdk.java.net/%7Esherman/6975829/webrev/>
-Sherman
Looks fine. A minor comment is that you don't need to update this_off
and it might be clear to just set the offset field to this_off + consumed.
-Alan.
wow, good catch:-)
Done.
http://cr.openjdk.java.net/~sherman/6975829/webrev/
<http://cr.openjdk.java.net/%7Esherman/6975829/webrev/>