Alan,
It appears we do have a regression test [1] in our repository to make
sure that
we do NOT do round-trip more than necessary for "short" input. While the
change
in http://cr.openjdk.java.net/~sherman/6975829/webrev
<http://cr.openjdk.java.net/%7Esherman/6975829/webrev.00/>.00
<http://cr.openjdk.java.net/%7Esherman/6975829/webrev.00/> does not "break"
anything, it does go to the inflater more than once for this corner case.
I updated the webrev to add some "overhead" bytes. This "20 bytes" overhead
probably will make some other corner cases less optimistic, but that
would not
be a regression.
http://cr.openjdk.java.net/~sherman/6975829/webrev
<http://cr.openjdk.java.net/%7Esherman/6975829/webrev/>
-Sherman
[1] test/java/util/ZipFile/ShortRead.java
On 10/05/2010 12:34 PM, Alan Bateman wrote:
Xueming Shen wrote:
:
wow, good catch:-)
Done.
http://cr.openjdk.java.net/~sherman/6975829/webrev/
<http://cr.openjdk.java.net/%7Esherman/6975829/webrev/>
Looks much better. Thumbs up form me.
-Alan
