Not a problem on both counts. I will update the webrev shortly. Revised webrev, when it appears, will be at:
http://cr.openjdk.java.net/~mduigou/6546713/1/webrev/ Mike On Apr 19 2011, at 18:07 , David Holmes wrote: > Hi Mike, > > Mike Duigou said the following on 04/20/11 08:00: >> Hello All; >> Another collections javadoc review request. This change links the >> "(optional)" notes in on various Collection methods to text which explains >> why they are not thrown by all collections. > > Generally looks good. I think you should revert this additional change in > Collection.java: > > ! * @throws NullPointerException if the specified array is {@code null} > > "null" is used all over the place without being code font, including other > @throws NullPointerException. > >> I have not applied the change to java.util.concurrent package javadoc. I >> will leave the JSR 166 maintainers. > > Yeah well ... on behalf of them can I twist your arm? If it isn't done now it > needs another CR, etc etc. Appears to be 22 cases across 4 classes. Maybe I > can generate the patch for you ... :) > > Cheers, > David > >> http://cr.openjdk.java.net/~mduigou/6546713/0/webrev/ >> Thanks, >> Mike
