On Apr 20, 2011, at 7:41 AM, Doug Lea wrote:
> On 04/19/11 21:07, David Holmes wrote:
>> Hi Mike,
>>
>> Mike Duigou said the following on 04/20/11 08:00:
>>> Hello All;
>>>
>>> Another collections javadoc review request. This change links the
>>> "(optional)"
>>> notes in on various Collection methods to text which explains why they are
>>> not
>>> thrown by all collections.
>>
>> Generally looks good. I think you should revert this additional change in
>> Collection.java:
>>
>> ! * @throws NullPointerException if the specified array is {@code null}
>>
>> "null" is used all over the place without being code font, including other
>> @throws NullPointerException.
>
> This, along with literals "true" and "false" are not code-fonted
> very consistently. Someday someone should do a big consistency pass
> across the whole code base.
Perhaps we can document what we believe the standards should be WRT when to use
{@code} . I am sure I have clean up to do throughout the JDBC as well for
consistency in this area
Regards,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected]
