Thanks for all the feedback.
changes:
- use diamond in JarIndex (style issue)
- sun.misc.Service -> java.util.ServiceLoader
in InetAddress and HttpServerProvider
- ExtensionDependency: suppress unchecked on declaration/assignment
http://cr.openjdk.java.net/~chegar/7116722/webrev.01/webrev/
-Chris.
On 30/11/2011 19:02, Lance Andersen - Oracle wrote:
Hi Chris,
Do you want to use diamond reference on lines 81, 82 of jarindex.java?
In Signal.java, line 203, i do not think you need new Integer() any longer?
Other than that it looks good
Best
Lance
On Nov 30, 2011, at 11:33 AM, Chris Hegarty wrote:
I started to look at the reason why we suppressed unchecked warning
for sun.misc.Service in a few places, and this lead me into some other
sun.misc classes. Here's a change that fixes a few warnings in this area.
http://cr.openjdk.java.net/~chegar/7116722/webrev.00/webrev/
-Chris.
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>
