On 20/12/2011 00:12, David Holmes wrote:
Brandon,
I don't see the purpose of NewAbstractSet. It is identical to
NewAbstractCollection.
Otherwise my only concern is as you raised previously, updating the
test to check existing subclasses causes new failures for ArrayList
and CopyOnWriteArrayList. I'd suggest fixing ArrayList as part of this
CR and file a new CR for COWAL so that Doug Lea can fix it upstream in
the jsr166 cvs repository.
Just to add to David's comments, if the change to COWAL/COWAS is
separated into its own bug then it means that MOAT will need to skip the
retainAll/removeAll(null) tests for these collections as we can't have
this test (or any other) failing.
-Alan.
