Alan,
On 23/12/2011 02:22, Kumar Srinivasan wrote:
Hi,
This fixes a bug in launcher where showSettings in conjunction with
-version
will do both and exit successfully. Thanks to Sean for pointing this
out.
Here is the webrev:
http://cr.openjdk.java.net/~ksrini/7123582/
Thanks
Kumar
Looks okay to me except in the test where runTest7123582 is named
differently to the other run* methods in this test.
The others were part of the feature, but this one is a regression.
These comprehensive tests become a pain in the future to determine
when a particular method maps to a CR, so we tend to use a
comment with CR in these places, but comments sometimes get lost
when shuffling code around, by naming the method with a CR makes
it self-explanatory.
Kumar
-Alan
