On 23/12/2011 14:36, Kumar Srinivasan wrote:
The others were part of the feature, but this one is a regression.

These comprehensive tests become a pain in the future to determine
when a particular method maps to a CR, so we tend to use a
comment with CR in these places, but comments sometimes get lost
when shuffling code around, by naming the method with a CR makes
it self-explanatory.

Kumar
The tests will outlive the current bug database and not clear (at least not to me) how easy it will be to map these CR numbers to the bug information. In this case I probably would have named is something like runTestShowSettingsAndVersion and mentioned the CR in the comment if needed. However, this is your area and what you have is fine.

-Alan.

Reply via email to