On 12/21/2012 7:43 AM, David DeHaven wrote:
Request for review for extending the launcher support to allow the JavaFX
runtime to fully support all of it's launch features, including preloaders,
classpath, etc..
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ddehaven/8004547/webrev.1/
>
> FXHelper.canLauncherFXAppJar launches a JAR with JavaFX-Application-Class. In the current version (before this fix), a FX JAR whose manifest can have a Main-Class entry that specifies the JavaFX application class that extends javafx.application.Application. Is that case no longer supported? Other than that, looks good.
Yes, it's handled. If there is no JavaFX-Application-Class and if the class
defined by Main-Class extends Application then that will be detected later and
launched using LM_CLASS instead of LM_JAR. Two of the tests specifically target
this condition (lines 218 and 268).
Later I figured out that too. In that case, I think
loadJavaFxLauncher() is called twice. LM_CLASS may be used for a JAR
file with a Main-Class pointing to a FX application entry point which is
confusing. So the fxlauncher only needs to know the main class but not
any other information in the JAR manifest?
In any case, if LM_JAR only means to launch a JAR file with a
JavaFX-Application-Class entry in the manifest, it's not really a JAR
mode and perhaps better to rename it too.
Thanks
Mandy
