On Jan 11, 2013, at 2:05 PM, Joe Wang wrote: > > > On 1/11/2013 8:58 AM, Alan Bateman wrote: >> On 09/01/2013 14:28, Daniel Fuchs wrote: >>> Hi, >>> >>> Here is a new webrev in the series that addresses using ServiceLoader in >>> JAXP for JDK 8. >>> >>> 7169894: JAXP Plugability Layer: using service loader >>> >>> This changeset addresses modification in the javax.xml.validation >>> package. >>> >>> It is a bit more complex than the changes required for the other >>> packages because the newInstance methods takes an additional >>> schemaLanguage parameter, and therefore we need to loop over >>> the providers in order to find one that supports the language. >>> >>> >>> <http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.validation/webrev.00/> >>> >>> >>> Also this particular package did not have any specific configuration >>> error to throw in case of misconfiguration (the xpath package in which >>> the logic is very similar had one for instance), so we're adding a new >>> SchemaFactoryConfigurationError for that purpose. >> I've taken an initial look at this and I'm wondering about >> SchemeFactory.newInstance throwing SchemaFactoryConfigurationError. >> Technically this is an incompatible change but in practical terms it may not >> be concern as this provider interface may not be used very much. >> >> Joe Wang - have you come across SchemaFactory implementations, I'm trying to >> get a feel for how much this is used, if ever. > > I don't have any data on how much the service mechanism may be used, Xerces > would surely be the one most frequently used. I'm more concerned with the > spec change that would require TCK change (the addition of > SchemaFactoryConfigurationError related tests). Would that require MR? We > probably need to run it with the JCK engineers.
If you are changing the exception, then you would need an MR for this and want to update any TCK/JCK tests (or add tests) > > Joe > >> >> -Alan
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
