Thank you Ulf. I deleted the extra line on 579
Best Lance On Jan 15, 2013, at 3:45 PM, Ulf Zibis wrote: > Looks great! > > Little nit: > SQLOutputImpl.java line 579 could be dropped. > > -Ulf > > > Am 15.01.2013 17:48, schrieb Lance Andersen - Oracle: >> Here is a revision >> >> http://cr.openjdk.java.net/~lancea/8006139/webrev.01 >> >> I still have to enter the JBS entry for the javadoc clarifications (and I >> also found another javadoc issue that was due to incorrect cut & paste when >> the code was written) and ccc request >> >> As i mentioned in an earlier thread, these classes are hardly ever, if at >> all used and would only be used when UDTs are used and the majority of >> databases do not support this. >> >> >> Best >> lance >> On Jan 14, 2013, at 5:11 AM, Alan Bateman wrote: >> >>> On 13/01/2013 23:51, Lance Andersen - Oracle wrote: >>>> : >>>> >>>>>> One other thing is that the CCE has a side-effect in that it "consumes" >>>>>> the next attribute. The methods could be changed to peek at the next >>>>>> attribute but that wouldn't work without synchronization or making it >>>>>> clear in the spec that the it is not a thread-safe implementation of >>>>>> SQLInput. >>>> I really want to keep the changes to the bare minimum here as this and the >>>> other serial classes are hardly, if ever used at all. >>> I understand, but if you add a catch-all in the class description to cover >>> the CCE case then this could be part of the same paragraph. >>> >>> -Alan >> >> >> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 >> Oracle Java Engineering >> 1 Network Drive >> Burlington, MA 01803 >> lance.ander...@oracle.com >> >
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
