On Jan 19, 2013, at 9:43 AM, Alan Bateman wrote: > On 15/01/2013 16:48, Lance Andersen - Oracle wrote: >> Here is a revision >> >> http://cr.openjdk.java.net/~lancea/8006139/webrev.01 >> >> I still have to enter the JBS entry for the javadoc clarifications (and I >> also found another javadoc issue that was due to incorrect cut& paste when >> the code was written) and ccc request >> >> As i mentioned in an earlier thread, these classes are hardly ever, if at >> all used and would only be used when UDTs are used and the majority of >> databases do not support this. >> > It would be good to get the ClassCastException specified when you get time.
Yes will do once the ccc is approved on my list > > I looked at the latest webrev and it seems okay to me. > SQLInputImpl.getNextAttribute would be bit better if it only incremented idx > after retrieving an attribute but that is existing code. Minor intent issue > in SQLOutputImpl. writeNClob. > fixed the spacing. going to leave idx alone for now as but will look at this for the future Best Lance > -Alan.
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com