On 23/02/2013 19:39, Peter Levart wrote:
Hi Nils,
If the counters are updated frequently from multiple threads, there
might be contention/scalability issues. Instead of synchronization on
updates, you might consider using atomic updates provided by
sun.misc.Unsafe, like for example:
Most of the jvmstat counters are in VM and we only update a small number
of counters in the libraries. Even so, I think your idea is good as
further usage could potentially to be an issue, particularly
add/increment (which involves a get at this). So irrespective of Nil's
patch (which I think is now just a proposal to add a counter, not
original patch that Jason was commenting on) then we should take your patch.
-Alan