Oops: I forgot to include core-libs-dev Forwarded conversation Subject: RFR: Optimize StringBuilder.append(null) ------------------------
From: *Martin Buchholz* <marti...@google.com> Date: Tue, Mar 26, 2013 at 1:54 PM To: Xueming Shen <xueming.s...@oracle.com>, Masayoshi Okutsu < masayoshi.oku...@oracle.com>, Ulf Zibis <ulf.zi...@cosoco.de>, Mike Duigou < mike.dui...@oracle.com> Hi! It's me again, fiddlling with StringBuilder. One of our users noticed that a lot of CPU time was being spent in StringBuilder.append(null). We can apply the previously proven optimization that improves it by a factor of 2 on microbenchmarks. http://cr.openjdk.java.net/~martin/webrevs/openjdk8/StringBuilder.appendNull/ ---------- From: *Mike Duigou* <mike.dui...@oracle.com> Date: Tue, Mar 26, 2013 at 1:58 PM To: Martin Buchholz <marti...@google.com> Cc: Xueming Shen <xueming.s...@oracle.com>, Masayoshi Okutsu < masayoshi.oku...@oracle.com>, Ulf Zibis <ulf.zi...@cosoco.de> This looks fine to me. Do you need a bug number? Mike ---------- From: *Martin Buchholz* <marti...@google.com> Date: Tue, Mar 26, 2013 at 2:02 PM To: Mike Duigou <mike.dui...@oracle.com> Cc: Xueming Shen <xueming.s...@oracle.com>, Masayoshi Okutsu < masayoshi.oku...@oracle.com>, Ulf Zibis <ulf.zi...@cosoco.de> On Tue, Mar 26, 2013 at 1:58 PM, Mike Duigou <mike.dui...@oracle.com> wrote: > This looks fine to me. Do you need a bug number? > > Yes, I do (thanks!) ---------- From: *Mike Duigou* <mike.dui...@oracle.com> Date: Tue, Mar 26, 2013 at 2:12 PM To: Martin Buchholz <marti...@google.com> Cc: Xueming Shen <xueming.s...@oracle.com>, Masayoshi Okutsu < masayoshi.oku...@oracle.com>, Ulf Zibis <ulf.zi...@cosoco.de>, Jim Gish < jim.g...@oracle.com> I have created: JDK-8010849: (str) Optimize StringBuilder.append(null) (yes we know that requiring an Oracle engineer create the bug is a problem. SOON!) Mike ---------- From: *Mike Duigou* <mike.dui...@oracle.com> Date: Tue, Mar 26, 2013 at 6:57 PM To: Martin Buchholz <marti...@google.com> Hi Martin; I hadn't originally noticed but can you make sure to send a RFR through core-libs-dev for this issue? Mike
