Re: RFR: Optimize StringBuilder.append(null)

[Jim Gish]

Thanks, Martin,

We've all heard of code "smells" -- I hereby dub this a code "chuckle"  :-)

The change looks good to me otherwise as well.

Thanks,
   Jim

On 03/28/2013 12:05 PM, Martin Buchholz wrote:

I took Laurent's suggestion of renaming count to c, even though the result
looks like a value judgement on a competing programming environment:

         value[c++] = 'n';
         value[c++] = 'u';
         value[c++] = 'l';
         value[c++] = 'l';



On Wed, Mar 27, 2013 at 11:42 PM, Laurent Bourgès <bourges.laur...@gmail.com

wrote:
Maybe the local var count could be renamed _count or c to avoid name
conflict with the member count and make the code more readable / obvious.

--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.g...@oracle.com