On 04/15/2013 02:02 PM, Martin Buchholz wrote:
You are fiddling with the javadoc for getChars, which is an independent change. (I am also fiddling with getChars in another ongoing change). I don't think closing html tags for <li> are required in javadoc. If you are going to change the exception javadoc, then also change @exception to @throws.

The only reason I'm adding </li> is Alan insisted on it in a previous change I proposed :-)

Jim

On Thu, Apr 11, 2013 at 3:33 PM, Jim Gish <jim.g...@oracle.com <mailto:jim.g...@oracle.com>> wrote:

    Please review
    http://cr.openjdk.java.net/~jgish/Bugs-5015163-7175206-7172553/
    <http://cr.openjdk.java.net/%7Ejgish/Bugs-5015163-7175206-7172553/> 
<http://cr.openjdk.java.net/%7Ejgish/Bugs-5015163-7175206-7172553/>

    These are changes that we made in lambda that we're now bringing
    into JDK8.

    I've made a couple of additions - making StringJoiner final and
    adding a couple of constructors to set the emptyOutput chars.

    Thanks,
       Jim

-- Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
    <tel:%2B1.781.442.0304>
    Oracle Java Platform Group | Core Libraries Team
    35 Network Drive
    Burlington, MA 01803
    jim.g...@oracle.com <mailto:jim.g...@oracle.com>



--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.g...@oracle.com

Reply via email to