http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos that were pointed out and also fixes a couple javadoc warnings
Best, Lance On Apr 22, 2013, at 11:17 AM, Lance Andersen - Oracle wrote: > > On Apr 22, 2013, at 9:13 AM, Alan Bateman wrote: > >> On 21/04/2013 12:45, Lance Andersen - Oracle wrote: >>> : >>>> >>>> DriverManager >>>> >>>> - one point that isn't covered in the spec is whether the DriverAction's >>>> deregister is invoked before or after it is deregistered. This distinction >>>> is probably only interesting for the case that the deregister method fails >>>> with an error/exception but it's not clear if the driver is still >>>> registered in that case. For completeness then the spec should probably >>>> say that any error/runtime exception is propagated to the caller of >>>> deregisterDriver. >>>> >>>> - could the new (and the original) registerDriver methods specify the >>>> behavior for the case that the Driver is already registered? This brings >>>> up the question as to whether the DriverAction is overridden if already >>>> registered. >>> clarified >> Thanks, I think that covers all the corner cases. >> >> One typo, line 376, should be "If the specified ...". > > Fixed that thank you. >> >> -Alan. >> > > > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > lance.ander...@oracle.com >
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
