I will make both suggested changes.

Thank you.

Mike

On Apr 30 2013, at 20:34 , Mandy Chung wrote:

> 
> On 4/30/2013 3:45 PM, Mike Duigou wrote:
>> Hello all;
>> 
>> Another changeset coming from the lambda libraries effort. This one is two 
>> small additions to the Objects class. The introduced methods are not really 
>> intended to be used directly, comparison operators work better in imperative 
>> logic, but the methods will be very useful as Predicates.
>> 
>> http://cr.openjdk.java.net/~mduigou/JDK-8013712/0/webrev/
> 
> This looks fine.  Minor nit: s/null/{@code null} in the javadoc.
> 
> It'd be good to add simple test cases to the existing test 
> test/java/util/Objects/BasicObjectsTest.java for these 2 methods.
> 
> Mandy
> 

Reply via email to