Thank you for the review Martin.
On Jun 7 2013, at 14:51 , Martin Buchholz wrote:
> <tt> is denigrated in favor of {@code ?
Yes. {@code} is preferred because it treats the content as literals. This means
you can use it to wrap text (usually generics) that have to represented using
html entities (& < >) or would be interpreted as html tags.
<tt>List<A extends Awesome & Comparable<? super Awesome>></tt>
vs
{@code List<A extends Awesome & Comparable<? super Awesome>>}.
The {@code} form is less error prone. I would love to do this replacement
globally along with <i> -> <em> and <b> -> <strong>
> ---
>
> "specified navigable set" ?
>
> + * The returned navigable set will be serializable if the specified
> sorted set
> + * is serializable.
Corrected.
> ---
>
> Y U NO throw UOE?
>
> + @Override
> + public Entry<K, V> pollFirstEntry() {
> + Entry<K,V> entry = (Entry<K,V>) nm.pollFirstEntry();
> + return (null == entry) ? null : new
> UnmodifiableEntrySet.UnmodifiableEntry(entry);
> + }
Ouch! I will fix this and see what additional test improvements this suggests.
>
> ---
> navigable set?
>
> + * Returns a synchronized (thread-safe) sorted set backed by the
> specified
> + * navigable set. In order to guarantee serial access, it is critical
> that
Corrected.
>
> On Fri, Jun 7, 2013 at 10:58 AM, Mike Duigou <[email protected]> wrote:
> Hello all;
>
> I've incorporated feedback from previous rounds and expect to finalize this
> addition soon.
>
> http://cr.openjdk.java.net/~mduigou/JDK-7129185/2/webrev/
>
> Any review feedback or suggestions of additional tests welcome.
>
> Thanks,
>
> Mike
>
>
>
