I'm not a reviewer, but I am happy to see that you always print the random seed, and not just in the case of graceful test failure -- because otherwise if the VM crashes, too bad for the poor fool who has to try to reproduce that.
David On 2013-06-18, at 8:59 PM, Mike Duigou <mike.dui...@oracle.com> wrote: > I have now updated MOAT to test the Collections wrappers. I hope that adding > additional classes doesn't take the already long runtime of this class over > the timeout threshold. > > The revised webrev, which includes only changes to tests, is here: > > http://cr.openjdk.java.net/~mduigou/JDK-7129185/6/webrev/ > > The very pleasing news is that nothing failed! > > Mike > > On Jun 18 2013, at 15:34 , Martin Buchholz wrote: > >> >> Looking at MOAT.java, I'm a little surprised that I didn't systematically >> test the implementations in Collections.java, even though e.g. it has a >> section for empty collections. How hard would it be to add such support? >
