On 17/06/2013 13:32, Aleksey Shipilev wrote:
On 06/17/2013 03:44 PM, Alan Bateman wrote:
This looks to good. I agree with Peter's point about the 2 reads in
getInterfaces() although it's unlikely to make a significant
difference.
Oh, it can have the difference on non-x86 hardware and/or in optimized
code. This nit is fixed here:
http://cr.openjdk.java.net/~shade/8016236/webrev.04/
I did the same testing as before: Linux x86_64/release builds and runs
jdk/test/java/lang/reflect jtreg successfully; the performance is still
there.
If you can create the change-set then I can push this for you today.
Here:
http://cr.openjdk.java.net/~shade/8016236/8016236.changeset
Although only Alan counts as official reviewer; do we need another one?
The updated webrev looks good for me.
For the jdk repository then only one reviewer with "reviewer" role is
required. I see you have Peter and Paul listed in a Reviewed-by line so
I think we are good. Do you want Doug listed too as this started out as
a patch from Doug.
-Alan
